Build tools: update latest versions
#11742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humitos
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Thanks a lot for this PR. It looks great!
The only missing piece is another PR similar to readthedocs/readthedocs-docker-images#205 in that repository. I'll see if I can make it now.
humitos
reviewed
Nov 5, 2024
humitos
added a commit
to readthedocs/readthedocs-docker-images
that referenced
this pull request
Nov 5, 2024
|
I opened readthedocs/readthedocs-docker-images#209 with the last piece required to merge this PR. |
|
We will need to update the examples from this file as well: https://github.com/readthedocs/ext-theme/blob/5a602534cb7f6252123d29e35c8e15b75c7a8350/readthedocsext/theme/templates/projects/import_config.html |
humitos
added a commit
to readthedocs/readthedocs-docker-images
that referenced
this pull request
Nov 5, 2024
humitos
added a commit
to readthedocs/ext-theme
that referenced
this pull request
Nov 14, 2024
humitos
added a commit
to readthedocs/ext-theme
that referenced
this pull request
Nov 14, 2024
|
Thanks all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #11386 and #10808
Not sure if I missed anything. Looking into
scripts/compile_version_upload.sh, I don't know if the selectedvirtualenvversion works with 3.13 (in fact I don't know if that package has officially supported 3.13 yet).I initially wanted to raise an issue to support Node.js 22, but then I got curious and thought I could help speed up the process. Feel free to pick it up from here if there are other areas that need to be updated e.g. https://github.com/readthedocs/readthedocs-docker-images 🙂
Closes #11671
📚 Documentation previews 📚
docs): https://docs--11742.org.readthedocs.build/en/11742/dev): https://dev--11742.org.readthedocs.build/en/11742/